This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] new_ctxt_format in xc_linux_restore?

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] new_ctxt_format in xc_linux_restore?
From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date: Mon, 21 May 2007 14:30:27 +0800
Cc: "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>
Delivery-date: Sun, 20 May 2007 23:28:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C276FA51.7B42%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcebahFvG1cvgK/2Ssi3WsEHIZXg2QABwAKxAAAGnBA=
Thread-topic: [Xen-devel] new_ctxt_format in xc_linux_restore?
>From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
>Sent: 2007年5月21日 14:27
>On 21/5/07 06:37, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:
>> Guess following lines as typo since new context format is used to
>> support fast suspend with online vcpu context saved in image file:
>> if ( !new_ctxt_format ) <--- Opposite should be used here???
>>     ctxt.flags |= VGCF_online;
>> Or do I misunderstand save/restore logic? Also interested why
>> smp restore works if a true typo above. :-)
>It's the right way round. Old images may not include the VGCF_online
>(since it is a new flag). Since old images only ever include one saved
>and that VCPU is never offline, we just poke that flag in.
> -- Keir

Oh, I see. I didn't note that VGCF_online has been saved for all 
online cpus at suspend phase. This line is just specific to BSP of 
old format.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>