WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Enabling vtpm causes installation error

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Enabling vtpm causes installation error
From: "S.Çağlar Onur" <caglar@xxxxxxxxxxxxx>
Date: Sat, 19 May 2007 03:01:36 +0300
Cc: Ulrich Drepper <drepper@xxxxxxxxxx>
Delivery-date: Fri, 18 May 2007 17:00:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <464E3CA1.6050102@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: TÜBİTAK / UEKAE
References: <200705190238.10695.caglar@xxxxxxxxxxxxx> <464E3CA1.6050102@xxxxxxxxxx>
Reply-to: caglar@xxxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.7
19 May 2007 Cts tarihinde, Ulrich Drepper şunları yazmıştı: 
> S.Çağlar Onur wrote:
> > -+  struct sockaddr_un client_addr;
> > ++  struct sockaddr client_addr;
>
> This is very wrong.  struct sockaddr is basically an abstract type.  You
> never allocate objects of this type.  Add casts in places where
> client_addr is used.

Irgh, thanks! Here is the updated one;

Signed-off-by: S.Çağlar Onur <caglar@xxxxxxxxxxxxx>

diff -r aee991c7723a tools/vtpm/vtpm.patch
--- a/tools/vtpm/vtpm.patch     Wed May 09 16:34:47 2007 +0100
+++ b/tools/vtpm/vtpm.patch     Sat May 19 03:00:28 2007 +0300
@@ -579,7 +579,7 @@ diff -uprN tpm_emulator/tpmd.c vtpm/tpmd
 +        memset(&client_addr, 0, sizeof(client_addr));
 +        client_length = sizeof(client_addr);
 +
-+        vtpm_rx_fh = vtpm_tx_fh = accept(sockfd, &client_addr, 
&client_length);
++        vtpm_rx_fh = vtpm_tx_fh = accept(sockfd, (struct sockaddr 
*)&client_addr, &client_length);
 +      }
 +#endif
      }

Cheers
-- 
S.Çağlar Onur <caglar@xxxxxxxxxxxxx>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>