Re: [Xen-devel] [PATCH][HVM][SVM] Reintroduce ASIDs.

[Keir Fraser <keir@xxxxxxxxxxxxx>]

On 15/5/07 11:00, "Biemueller, Sebastian" <Sebastian.Biemueller@xxxxxxx>
wrote:

> This patch reintroduces ASID management for AMD-V.

A few more comments:
 1. Rather than adding an extra hook at every use of paging_update_cr3(),
paging_update_paging_modes(), paging_invlpg(), move those original calls
into your hook functions. Then the original invocation is simply replaced
with a call to your function, which can hide the extra work more neatly.

 2. Adding an extra function call on every vmentry is unfortunate. Why not
guarantee that any running SVM VCPU has a valid ASID at all times, even
while running inside Xen? This would mean that you would greedily allocate
an ASID as soon as you context-switch to a SVM VCPU, and also when the old
ASID becomes invalid. Then you could do your tests and VMCB-twiddling on
those less common paths, and avoid extra cost on the much more common
vmentry path.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel