This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [patch 02/28]xen: Add nosegneg capability to the vsyscal

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [patch 02/28]xen: Add nosegneg capability to the vsyscall page notes
From: Roland McGrath <roland@xxxxxxxxxx>
Date: Fri, 11 May 2007 13:07:44 -0700 (PDT)
Cc: Zachary Amsden <zach@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Pratt <ian.pratt@xxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Ulrich Drepper <drepper@xxxxxxxxxx>, Christian Limpach <Christian.Limpach@xxxxxxxxxxxx>
Delivery-date: Tue, 15 May 2007 01:50:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: Jeremy Fitzhardinge's message of Thursday, 10 May 2007 17:06:45 -0700 <20070511001156.003375000@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> + * It should contain:
> + *   hwcap 0 nosegneg
> + * to match the mapping of bit to name that we give here.

This comment still needs s/0/1/ to match the code.  Given that the actual
bit is now defined in the macro in another file, perhaps the comment should
say more about it than just a magic 1.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>