This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] x86/hvm: determine shared info format earlier

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86/hvm: determine shared info format earlier
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Tue, 15 May 2007 09:13:10 +0200
Delivery-date: Tue, 15 May 2007 00:10:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C26F18EC.75FB%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <46489AF4.76E4.0078.0@xxxxxxxxxx> <C26F18EC.75FB%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 15.05.07 08:59 >>>
>On 14/5/07 16:23, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>> Latch guest shared info format when hypercall page is being set up rather
>> than during an arbitrarily selected hypercall.
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
>I don't think this works since the PV drivers don't re-create the hypercall
>page after save/restore (bad us!).

This must be fixed then. I don't think it's appropriate for them to assume
the hypercall page doesn't change its layout across suspend.

>We could sample the execution mode in *both* places (new and old)?

Even if it gets fixed in the drivers?


Xen-devel mailing list