WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] 64-bit hvm on 32-bit dom0 - ioemu adjustments

To: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] 64-bit hvm on 32-bit dom0 - ioemu adjustments
From: Stephan Creutz <stephan.creutz@xxxxxxxxxxxxxxxxx>
Date: Mon, 14 May 2007 17:36:29 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 14 May 2007 08:35:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4648973D.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4648973D.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 14 May 2007 17:07:09 +0200
"Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Don't mask off data bits when running 64-bit hvm guests on 32-bit
> dom0.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> 
> Index: 2007-04-27/tools/ioemu/target-i386-dm/helper2.c
> ===================================================================
> --- 2007-04-27.orig/tools/ioemu/target-i386-dm/helper2.c      2007-04-23 
> 12:41:32.000000000 +0200
> +++ 2007-04-27/tools/ioemu/target-i386-dm/helper2.c   2007-05-09 
> 17:58:07.000000000 +0200
> @@ -322,7 +322,7 @@ void cpu_ioreq_pio(CPUState *env, ioreq_
>              do_outp(env, req->addr, req->size, req->data);
>          } else {
>              for (i = 0; i < req->count; i++) {
> -                unsigned long tmp;
> +                unsigned long tmp = 0;
>  
>                  read_physical((target_phys_addr_t) req->data
>                    + (sign * i * req->size),

I think tmp also should have the type target_ulong.

Stephan
-- 
PHP - it's "training wheels without the bike" -- Randal L. Schwartz

Attachment: pgpj2Ur6aEUnQ.pgp
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>