This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] Fix write parameter masking for 32-bit guests.

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] Fix write parameter masking for 32-bit guests.
From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date: Sun, 13 May 2007 15:49:22 +0800
Cc: Keir Fraser <keir@xxxxxxxxxxxxx>
Delivery-date: Sun, 13 May 2007 00:47:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceVMzhKOfboKd4hQNKFfDAIGnB8iA==
Thread-topic: [PATCH] Fix write parameter masking for 32-bit guests.
Changeset 15046:e527b4ff1948 breaks 32-bit HVM guest: when req->size is
4, "1UL << 32" returns 1 in IA32 system, so the mask becomes 0 wrongly.
The attached patch fixes this by using 64-bit left-shift.

Signed-off-by: Dexuan Cui <dexuan.cui@xxxxxxxxx>

Attachment: helper2.c.patch
Description: helper2.c.patch

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>