This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: [PATCH] Re: [Xen-staging] [xen-unstable] [qemu] Removeat

To: Christian Limpach <Christian.Limpach@xxxxxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH] Re: [Xen-staging] [xen-unstable] [qemu] Removeatomic_set_bit, atomic_clear_bit and ia64_intrinsic.h and its
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Thu, 10 May 2007 15:09:47 -0600
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 10 May 2007 14:15:02 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <0326530267625D42A4E36594FDD0D1437576D2@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: HP OSLO R&D
References: <200705101500.l4AF0N4b027027@xxxxxxxxxxxxxxxxxxxxxxx> <1178814917.27751.8.camel@bling> <0326530267625D42A4E36594FDD0D1437576D2@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2007-05-10 at 13:01 -0700, Christian Limpach wrote:
> >    ia64intrin.h is all but empty in gcc 4.1.2, so there's no point in
> > including it.  dm-exec is still making use of a few of these 
> > too, but I
> > guess it's easy enough to inline them there.  Patch below.  Thanks,
> Would it also work to just leave the include in exec-all.h?  I was
> confused and thought that it was a local include which is why I put
> #ifndef CONFIG_DM around all the testandset definitions.
> So, if I remove the #ifndef CONFIG_DM, anything including exec-all.h
> should still compile, right?  Do I still need the extra #define's in
> that case?

   ia64intrin.h is basically empty, so making it included for the
dm-exec build doesn't really help.  The defines still need to come from
somewhere.  We could replace <ia64intrin.h> with <asm/gcc_intrin.h>, but
for this trivial case, I'd rather not get tied up including kernel
headers in userspace tools.  Thanks,


Alex Williamson                             HP Open Source & Linux Org.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>