WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 0/4] Support accelerated network plugin modules

To: Kieran Mansley <kmansley@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/4] Support accelerated network plugin modules
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 08 May 2007 11:43:47 +0100
Delivery-date: Tue, 08 May 2007 03:42:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1178618095.4147.32.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceRXcGiABTiCf1REduQdAAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH 0/4] Support accelerated network plugin modules
User-agent: Microsoft-Entourage/11.3.3.061214
On 8/5/07 10:54, "Kieran Mansley" <kmansley@xxxxxxxxxxxxxx> wrote:

> 3/4:  Frontend net driver acceleration
>  - this provides hooks in the netfront driver to allow a plugin module
> to attach and be called at appropriate points.
> 
> 4/4:  Backend net driver acceleration
>  - this provides hooks in the netback driver to allow a plugin module to
> attach and be called at appropriate points.

These probably should be reviewed by someone like Herbert Xu for sanity. I
can immediately see that Linux coding style is not followed (lack of spaces
around if(){, and LOUD MACROS are two problems I can see).
netfront_stop_queue and friends look like pointless wrappers.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel