This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel][Xense-devel][PATCH][2/4] Xen Securtiy Modules: FLASK

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel][Xense-devel][PATCH][2/4] Xen Securtiy Modules: FLASK
From: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Date: Tue, 8 May 2007 04:15:47 +0100
Cc: "George S. Coker, II" <gscoker@xxxxxxxxxxxxxx>, xense-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 07 May 2007 20:15:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1178574074.6520.88.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1178574074.6520.88.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6
Hi George,

More coding style nits from my automated pedantry script.

> Updates in this patch set include:
>     - reintroduction of rcu locking support in security cache
>     - track xsm changes
> Signed-off-by: George Coker <gscoker@xxxxxxxxxxxxxx>

I've not attached the style checker output this one gave me because most of 
it's fairly homogeneous can be fixed by a regexp find/replace.  Issues 

Most Xen code spaces out the if conditional brackets like so:
    if ( !node_ptr )
if boolean operators are used in the expression they're also surrounded by 
space.  There are a number of places where Linux-style spacing is used 

Braces are always on their own line in the Xen code...  There are a number of 
places where this patch puts them on a line with another statement, K&R / 
Linux style.

I also found a number of instances of trailing whitespace, and of tabs being 
used for indentation instead of spaces.

All these things can probably be fixed using sed / emacs / etc so I've not 
attached the rather verbose output from the checker...  Please let me know if 
I can help speed things up and I'll send you more information.


Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>