This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] [Xen-API] Patch for fixing the rtc/timeoffset en

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [Xen-API] Patch for fixing the rtc/timeoffset entry
From: Stefan Berger <stefanb@xxxxxxxxxx>
Date: Mon, 7 May 2007 12:40:05 -0400
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ewan Mellor <ewan@xxxxxxxxxxxxx>
Delivery-date: Mon, 07 May 2007 09:38:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C264E1D7.6EB4%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote on 05/07/2007 09:01:59 AM:

> On 5/5/07 15:42, "Stefan Berger" <stefanb@xxxxxxxxxx> wrote:
> > This patch rewrites the rtc/timeoffset entry so the VM's record can be
> > retrieved with the Java xmlrpc library. If the entry is 'None' it upsets
> > the xmlrpc parser. This fixes it, though maybe there's a better place in
> > xend to place similar code.
> Can't the second argument to vm_details.get() be changed to "0"? If not,
> could you just do 'foo = vm_details.get(...) or "0"'?

The problem is that the 'get' only falls back to the default (currently passed as '0'), if the member of the dictionary is not set at all. Unfortunately the member has the value 'None'. Probably the value "0" should be assigned in the initialization of the dictionary.


>  -- Keir
Xen-devel mailing list