WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Segments can span multiple clusters with tap:qco

To: Mark McLoughlin <markmc@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Segments can span multiple clusters with tap:qcow
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 26 Apr 2007 11:00:54 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 26 Apr 2007 02:59:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1177579115.3487.27.camel@blaa>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceH6ccNBch++fPdEduFMQAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Segments can span multiple clusters with tap:qcow
User-agent: Microsoft-Entourage/11.3.3.061214
On 26/4/07 10:18, "Mark McLoughlin" <markmc@xxxxxxxxxx> wrote:

>> The current code allocates aio-request info for every segment in a request
>> ring (MAX_AIO_REQUESTS == BLK_RING_SIZE * MAX_SEGMENTS_PER_REQUEST). This
>> patch seems to take into account that each segment (part-of-page) can itself
>> be split into clusters, hence the page_size/cluster_size calculation, but
>> shouldn't this be multiplied by the existing MAX_AIO_REQUESTS? Otherwise you
>> provide only enough aio requests for one segment at a time, rather than a
>> request ring's worth of segments?
> 
> Absolutely, well spotted. I fixed that typo after testing, but
> obviously forgot to run "quilt refresh" before sending ...
> 
> Fixed version attached.

This one doesn't build (free_aio_state: line 164: structure has no member
named 'private'). Perhaps free_aio_state() should take a 'struct
disk_driver' rather than a 'struct td_state'?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel