|   | 
      | 
  
  
      | 
      | 
  
 
     | 
    | 
  
  
     | 
    | 
  
  
    |   | 
      | 
  
  
    | 
         
xen-devel
[Xen-devel] Re: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to s
 
| 
To:  | 
Ingo Molnar <mingo@xxxxxxx> | 
 
| 
Subject:  | 
[Xen-devel] Re: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable | 
 
| 
From:  | 
Jeremy Fitzhardinge <jeremy@xxxxxxxx> | 
 
| 
Date:  | 
Fri, 16 Mar 2007 11:39:43 -0700 | 
 
| 
Cc:  | 
Zachary Amsden <zach@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx,	virtualization@xxxxxxxxxxxxxx, Rusty Russell <rusty@xxxxxxxxxxxxxxx>,	linux-kernel@xxxxxxxxxxxxxxx, William Lee Irwin III <wli@xxxxxxxxxxxxxx>,	Chris Wright <chrisw@xxxxxxxxxxxx>, Andi Kleen <ak@xxxxxx>,	Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> | 
 
| 
Delivery-date:  | 
Fri, 16 Mar 2007 11:39:04 -0700 | 
 
| 
Envelope-to:  | 
www-data@xxxxxxxxxxxxxxxxxx | 
 
| 
In-reply-to:  | 
<20070316093348.GS23174@xxxxxxx> | 
 
| 
List-help:  | 
<mailto:xen-devel-request@lists.xensource.com?subject=help> | 
 
| 
List-id:  | 
Xen developer discussion <xen-devel.lists.xensource.com> | 
 
| 
List-post:  | 
<mailto:xen-devel@lists.xensource.com> | 
 
| 
List-subscribe:  | 
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> | 
 
| 
List-unsubscribe:  | 
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> | 
 
| 
References:  | 
<20070301232443.195603797@xxxxxxxx>	<20070301232526.611972133@xxxxxxxx>	<20070316093348.GS23174@xxxxxxx> | 
 
| 
Sender:  | 
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx | 
 
| 
User-agent:  | 
Thunderbird 1.5.0.10 (X11/20070302) | 
 
 
 
Ingo Molnar wrote:
>> +    /* Make sure kernel address space is empty so that a pagetable
>> +       will be allocated for it. */
>>     
>
> comment style.
>   
As you've noticed its a comment style I use quite often.  I use it for
what's essentially a little local comment, rather than a block comment
which really needs to draw attention to itself.  In this case, I think using
/*
 * Make sure kernel address space is empty so that a pagetable
 * will be allocated for it.
 */
is just too loud for what its trying to say.  If // comments were deemed
acceptable, I'd probably use them here instead.
    J
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 |   
 
 | 
    | 
  
  
    |   | 
    |