[Xen-devel] Re: HVM save/restore issue

[Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>]

At 15:48 +0800 on 15 Mar (1173973722), Zhai, Edwin wrote:
> all,
> there are 2 issues of HVM save/restore:
> 1. restore would cause a type dismatch exception, which can be fixed by 
> attached 
> patch.

I can't reproduce this exception. 

>      if is_hvm:
>          hvm  = dominfo.info['memory_static_min']
> -        apic = dominfo.info['platform'].get('apic', 0)
> -        pae  = dominfo.info['platform'].get('pae',  0)
> +        apic = int(dominfo.info['platform'].get('apic', 0))
> +        pae  = int(dominfo.info['platform'].get('pae',  0))

AFAICS, 'apic' and 'pae' are mapped through str() when they're used, so I
don't see that it helps to cast them to integers now.
Is there a reason you don't pass 'hvm' through int() as well?

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, XenSource UK Limited
Registered office c/o EC2Y 5EB, UK; company number 05334508

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel