WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] hvm_init_ap_contexts

To: "Keir Fraser" <keir@xxxxxxxxxxxxx>, "PUCCETTI Armand" <armand.puccetti@xxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: RE: [Xen-devel] hvm_init_ap_contexts
From: "Petersson, Mats" <Mats.Petersson@xxxxxxx>
Date: Thu, 1 Mar 2007 18:25:41 +0100
Delivery-date: Thu, 01 Mar 2007 09:25:09 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C20CB70C.A6F4%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdcIwm3SINX48gWEduJ9AAX8io7RQAA2Rxg
Thread-topic: [Xen-devel] hvm_init_ap_contexts
 

> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of 
> Keir Fraser
> Sent: 01 March 2007 17:00
> To: PUCCETTI Armand; xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] hvm_init_ap_contexts
> 
> The return keyword is pointless here, but allowed.

Agreed - but removing the return keyword would make sure that someone
looking at the code doesn't try to figure out what is being returned by
the original function - and since there's nothing being returned, not
using a return keyword makes the code "clearer". 

My personal opinion, of course. 

--
Mats
> 
>  -- Keir
> 
> On 1/3/07 16:42, "PUCCETTI Armand" <armand.puccetti@xxxxxx> wrote:
> 
> > Why is there an argument returned in the function below (of hvm.h),
> > knowing that there is void?
> > 
> > static inline void
> > hvm_init_ap_context(struct vcpu_guest_context *ctxt,
> >                    int vcpuid, int trampoline_vector)
> > {
> >    return hvm_funcs.init_ap_context(ctxt, vcpuid, 
> trampoline_vector);
> > }
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel