WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Make x86_64 swiotlb code to support dma_ops [2/2

To: "Langsdorf, Mark" <mark.langsdorf@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Make x86_64 swiotlb code to support dma_ops [2/2]
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Wed, 28 Feb 2007 21:23:40 +0000
Delivery-date: Wed, 28 Feb 2007 13:22:38 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1449F58C868D8D4E9C72945771150BDFD96682@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdbdXGgPI0XllCdQlK5GGtYpF745wACUWEG
Thread-topic: [Xen-devel] [PATCH] Make x86_64 swiotlb code to support dma_ops [2/2]
User-agent: Microsoft-Entourage/11.3.3.061214
On 28/2/07 20:17, "Langsdorf, Mark" <mark.langsdorf@xxxxxxx> wrote:

> The first patch creates the arch/x86_64/kernel/pci-dma-xen.c
> file based on the standard pci-dma.c, and creates
> arch/x86_64/kernel/swiotlb-xen.c based on
> arch/i386/kernel/swiotlb.c.

Do we really need to duplicate the swiotlb code? Did you need to make big
changes?

Other points that I can see from a quick browse include the fact that
alloc_coherent() still looks broken afaics and the one-liner in
io_apic-xen.c is a bit random (since none of the other use-iommu-or-not
decision points are changed, and the GART stuff which is presumably what is
being kludged around is not even included in Xen builds yet).

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel