WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86/PAE partially linear page table support

To: Jan Beulich <jbeulich@xxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86/PAE partially linear page table support
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 15 Feb 2007 11:58:17 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 15 Feb 2007 03:57:42 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45D454F0.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdQ+JQX0ulbCLzrEdu/0gAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] x86/PAE partially linear page table support
User-agent: Microsoft-Entourage/11.2.5.060620


On 15/2/07 11:41, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>> How do you ensure that circular references are correctly cleaned up at
>> domain destruction time? (i.e., A references B and B references A).
>> 
>> We have special destructore code to clean up all root pagetable references,
>> but the code isn't there for lower levels.
> 
> put_page_from_l?e() are all symmetrical, i.e. should take care of such
> references at any level. I don't think I know what other destructor code
> is involved here.

That's not what I mean. Say we have two L2 tables, A and B. A[0] references
B and B[0] references A. Even when all external references to A and B have
gone away (i.e., there are no references from L3 tables) the type counts of
A and B will both be non-zero because of the circular reference. This will
prevent the pages from being freed and, ultimately, can lead to the domain
never being destroyed.

This case needs to be handled. See the code just below the largest comment
in arch/x86/domain.c:relinquish_memory() to see how it's handled for
top-level pagetables. Unfortunately it doesn't quite trivially generalise.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel