This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] Fix xm create command for wrong scheduler parameters

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] Fix xm create command for wrong scheduler parameters
From: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Date: Tue, 06 Feb 2007 15:10:48 +0900
Delivery-date: Mon, 05 Feb 2007 22:10:46 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

When I tested the xm create command with wrong scheduler parameters, 
a domain existed with the paused state. Usually, if an error occurred 
by the xm create command, the domain isn't created. 
The xm start command also has same issue. 

# xm create /xen/vm1.conf cpu_weight=99999
Using config file "/xen/vm1.conf".
Error: weight is out of range
# xm create /xen/vm2.conf cpu_cap=999
Using config file "/xen/vm2.conf".
Error: cap is out of range
# xm list
Name                                      ID   Mem VCPUs      State   Time(s)
Domain-0                                   0   491     2     r-----    594.5
vm1                                        6   256     1     --p---      0.0
vm2                                        7   256     1     --p---      0.0

This patch fixes the issue. If the xm create command fails with 
wrong scheduler parameters, it destroys the domain in the proceeding 
of xm create command. 

Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,

Attachment: xm_create.patch
Description: Binary data

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>