WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] pypxeboot bootloader

To: Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] pypxeboot bootloader
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: Mon, 5 Feb 2007 17:57:53 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Stephen Childs <Stephen.Childs@xxxxxxxxx>
Delivery-date: Mon, 05 Feb 2007 09:57:30 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070205173612.GH5181@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <45C7114E.10207@xxxxxxxxx> <20070205173612.GH5181@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Mon, Feb 05, 2007 at 05:36:12PM +0000, Tim Deegan wrote:

> Hi, 
> 
> At 11:13 +0000 on 05 Feb (1170673998), Stephen Childs wrote:
> > As promised on Friday here is the patch for the pypxeboot bootloader. It 
> > would be great if someone could try it out and give me some feedback.
> 
> First impressions: this looks really useful but has a few rough edges
> that need to be knocked off.  (I haven't had a chance to try this on a
> real machine yet.)
> 
> > +for line in udhcplines:
> > +    s = line.strip()
> > +    f = s.split()
> > +
> > +    if s[0]=='{' and s[-1]=='}':
> > +        dhcpinfo=eval(s, {"__builtins__" : {}})
> > +        for k in dhcpinfo:
> > +            dhcpinfo[k]=dhcpinfo[k].strip()
> 
> Executing the results of programs scares me.  Could you just parse it?
> 
> > +ipaddr=dhcpinfo['ip']
> > +ipaddrlist=ipaddr.split('.')
> > +hexip=commands.getstatusoutput("/usr/bin/gethostip -x "+ipaddr)[1]
> 
> This requires syslinux to be installed on the Xen host, and isn't 
> hard to do by hand: "%2.2x%2.2x%2.2x%2.2x" % tuple(map (int, ipaddrlist))
> (I'm sure more heavyweight python hackers can correct my style.)

(4 * "%2.2x") % tuple(map (int, ipaddrlist))

or

"".join(["%2.2x" % int(i) for i in ipaddrlist])

Both are pleasingly arcane...

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel