WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [PATCH][RESEND]RE: [Xen-devel] [PATCH] Fix softlockup issue aftervcp

To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [PATCH][RESEND]RE: [Xen-devel] [PATCH] Fix softlockup issue aftervcpu hotplug
From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date: Fri, 2 Feb 2007 21:57:26 +0800
Delivery-date: Fri, 02 Feb 2007 05:57:12 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <D470B4E54465E3469E2ABBC5AFAC390F9E11AD@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdESFqDCWsISfq5RGeHgxcxVzRqmQACelaDAAAZiDAAAP4q2wADxf1QAAFVV3AAAMUYXAAACCkwAACFZyAAAV9OMAABEoucACBxTEAATS41lQANfeFwAACGefIAAJFJTQAA88jJAAFt7gAAFoaGcA==
Thread-topic: [PATCH][RESEND]RE: [Xen-devel] [PATCH] Fix softlockup issue aftervcpu hotplug
Hi, Keir,
        Please check whether attached patch matches 
your suggestion. Test OK with vcpu hotplug and save/restore.

Thanks,
Kevin
 
>From: Tian, Kevin
>Sent: 2007年2月2日 10:49
>>Okay, I now see how this works -- the thread is kicked from
>>softlockup_tick(), from the timer ISR. So this wakeup event is hidden
>>from
>>next_timer_interrupt(), which only searches timer wheels and hrtimers.
>
>Exactly.
>
>>
>>The strictly correct fix here is to make next_timer_interrupt()
>>softlockup-aware. I would say it is currently incorrect in 
>the presence of
>>softlockup since it is not doing its job (telling an idle 
>process what the
>>next time-based event is that it must wake up for).
>>
>>We can do this by adding a softlockup_get_next_event(), 
>called from the
>>bottom of next_timer_interrupt(). I would pass it the current 
>return value
>>and have it return an adjusted value: so in the absence of 
>softlockup it
>>would simply return its argument unmodified. In the presence of
>>softlockup
>>it would return a sooner value if softlockup is the next 
>event to fire.
>>
>>Do you want to try coding this up?
>>
>> -- Keir
>
>Sure.
>
>Thanks,
>Kevin

Attachment: softlockup_fix.patch
Description: softlockup_fix.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel