WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] new domain builder fix to boot domU on IA64.

To: Gerd Hoffmann <kraxel@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] new domain builder fix to boot domU on IA64.
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Wed, 31 Jan 2007 11:56:08 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 30 Jan 2007 18:55:46 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45BF50EC.4020300@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070130122631.GI25482%yamahata@xxxxxxxxxxxxx> <45BF50EC.4020300@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Tue, Jan 30, 2007 at 03:06:36PM +0100, Gerd Hoffmann wrote:
> > +static int arch_setup_middle(struct xc_dom_image *dom)
> > +{
> >      DECLARE_DOMCTL;
> >      int rc;
> >  
> > @@ -268,16 +280,35 @@ static int arch_setup_early(struct xc_do
> >      domctl.cmd = XEN_DOMCTL_arch_setup;
> >      domctl.domain = dom->guest_domid;
> >      domctl.u.arch_setup.flags = 0;
> > +
> > +    /* dom->start_info_pfn should be initialized by alloc_magic_pages().
> > +     * However it is called later. So we initialize here.
> > +     */
> > +    dom->start_info_pfn = dom->total_pages - 3;
> 
> Is it an option to call arch_setup_middle as one of the first things in
> xc_dom_boot_image()?  That would avoid the start_info_pfn trickery ...
> 
> The only thing which happens between the current and the suggested place
> is that domU pages are mapped and data is copyed to them.  No other
> hypercalls.
>
> If that works out we might consider giving some more desciptive names to
> the arch hooks, such as "arch_setup_{meminit,bootearly,bootlate}" or so.

XEN_DOMCTL_arch_setup hypercall sets up EFI memory map,
xen-faked EFI firmware and etc. So it should be called before
loading kernel/initrd images.
Presumably such setting should be loader specific.
How about adding new methods like setup_meminit, setup_firmware, setup_boot
(Or please suggest better names.) to struct xc_dom_loader?
And call setup_meminit at xc_dom_boot_mem_init(),
         setup_firmware at the beginning of xc_dom_build_image(),
         setup_boot at xc_dom_boot_image().

-- 
yamahata

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel