WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] fix cross compiling ia64 on x86

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix cross compiling ia64 on x86
From: Gerd Hoffmann <kraxel@xxxxxxx>
Date: Tue, 30 Jan 2007 14:49:14 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 30 Jan 2007 05:48:51 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070130122214.GH25482%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070130122214.GH25482%yamahata@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.9 (X11/20060911)
> diff -r 5bb084098493 -r 94c3db4748b2 xen/include/public/foreign/Makefile
> --- a/xen/include/public/foreign/Makefile     Mon Jan 29 13:22:21 2007 +0000
> +++ b/xen/include/public/foreign/Makefile     Tue Jan 30 16:51:51 2007 +0900
> @@ -14,12 +14,8 @@ clean:
>       rm -f *.pyc *.o *~
>  
>  check-headers: checker
> -ifeq ($(CROSS_COMPILE),)
>       ./checker > $(XEN_TARGET_ARCH).size
>       diff -u reference.size $(XEN_TARGET_ARCH).size
> -else
> -     @echo "cross build: skipping check"
> -endif
>  
>  x86_32.h: ../arch-x86/xen-x86_32.h ../arch-x86/xen.h ../xen.h $(scripts)
>       python mkheader.py $* $@ $(filter %.h,$^)

Ok.

> diff -r 5bb084098493 -r 94c3db4748b2 xen/include/public/foreign/mkchecker.py
> --- a/xen/include/public/foreign/mkchecker.py Mon Jan 29 13:22:21 2007 +0000
> +++ b/xen/include/public/foreign/mkchecker.py Tue Jan 30 16:51:51 2007 +0900
> @@ -38,10 +38,7 @@ for struct in structs:
>  for struct in structs:
>      f.write('\tprintf("%%-20s |", "%s");\n' % struct);
>      for a in archs:
> -        if a == arch:
> -            s = struct; # native
> -        else:
> -            s = struct + "_" + a;
> +        s = struct + "_" + a;
>          f.write('#ifdef %s_has_no_%s\n' % (a, struct));
>          f.write('\tprintf("%8s", "-");\n');
>          f.write("#else\n");

No.  I intentionally use the native version here (struct foo instead of
struct foo_arch) to catch possible inconsistencies.

cheers,
  Gerd

-- 
Gerd Hoffmann <kraxel@xxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel