WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][RFC] correction trouble of short message in UDP

To: keir@xxxxxxxxxxxxx (Keir Fraser)
Subject: Re: [Xen-devel] [PATCH][RFC] correction trouble of short message in UDP
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 26 Jan 2007 00:40:28 +1100
Cc: t.horikoshi@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 25 Jan 2007 05:40:34 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C1DE526D.8316%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Core
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.6.17-rc4 (i686))
Keir Fraser <keir@xxxxxxxxxxxxx> wrote:
> On 25/1/07 11:04, "Tomonari Horikoshi" <t.horikoshi@xxxxxxxxxxxxxx> wrote:
> 
>> I confirmed the not error because of this correction.
>> Is there a better correction?
> 
> It's along the right lines so I check it in as is. However, you probably
> need to check that you have enough grant entries for worst-case packet
> fragmentation (a packet may require more than one grant). Or start_xmit()
> needs to be able to buffer one packet until it has enough grants to proceed
> with its transmission.

How about making the total number of grant table entries equal the
number of TX slots? That way we won't have to check anything at all.

It also doesn't make sense to have more TX slots than grant table entries.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel