Re: [Xen-devel] 32-on-64: pvfb issue

[Gerd Hoffmann <kraxel@xxxxxxx>]

  Hi,

>> @@ -560,10 +560,10 @@ int xenfb_attach_dom(struct xenfb *xenfb
>>      if (xenfb_wait_for_frontend_initialised(&xenfb->kbd) < 0)
>>              goto error;
>>  
>> -    if (xenfb_bind(&xenfb->fb) < 0)
>> -            goto error;
>>      if (xenfb_bind(&xenfb->kbd) < 0)
>>              goto error;
>> +    if (xenfb_bind(&xenfb->fb) < 0)
>> +            goto error;
>>  
>>      if (xenfb_xs_scanf1(xsh, xenfb->fb.otherend, "feature-update",
>>                          "%d", &val) < 0)
> 
> Why is this patch hunk necessary?

Oh, forgot to mention that, sorry.  Only vfb has a "protocol" node, vkbd
hasn't.  So binding fb last makes sure we have the protocol filled
correctly in the struct.

cheers,
  Gerd

-- 
Gerd Hoffmann <kraxel@xxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel