Re: [RFC] Re: [Xen-devel] [PATCH] fix xenctl_cpumap translation to handle bitops accessed like arrays

[Jimi Xenidis <jimix@xxxxxxxxxxxxxx>]

From the patch that you committed, AFAICT this function does not do  
anything:
void bitmap_byte_to_long(unsigned long *lp, const uint8_t *bp, int  
nbits)
{
        unsigned long l;
        int i, j, b;

        for (i = 0, b = 0; nbits > 0; i++, b += sizeof(l)) {
                l = 0;
                for (j = 0; (j < sizeof(l)) && (nbits > 0); j++) {
                        l <<= 8;
                        l |= bp[b+j];
                        nbits -= 8;
                }
                lp[i] = l;
        }
}

On Jan 17, 2007, at 8:55 AM, Keir Fraser wrote:

> On 17/1/07 12:50, "Jimi Xenidis" <jimix@xxxxxxxxxxxxxx> wrote:
>
> > > Actually, your
> > > 'no-op' long_to_byte_bitmap() implementation does not memcpy -- why
> > > is that?
> > This is a little (possibly dirty) attempt to avoid a copy if no
> > conversion is required.
> > As long as the caller uses the return value all is well.
> > I'd happy to make it a memcpy() and feel better about it.
> Yes please.
>
>  K.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel