|
|
![](http://www.xen.org/images/globals/pixel.gif) |
|
|
|
|
|
|
|
xen-devel
RE: [Xen-devel] [PATCH] Cleanup asm-x86/guest_access.h
> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of
> Christoph Egger
> Sent: 11 January 2007 14:54
> To: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: [Xen-devel] [PATCH] Cleanup asm-x86/guest_access.h
>
>
> Hi!
>
> I cleaned up xen/include/asm-x86/guest_access.h. I also fixed
> a bug in
> __copy_field_from_guest(), which seems to me to
> be a kind of cut-copy-paste bug.
>
> copy_{to,from}_user() and copy_{to,from}_user_hvm() expect a non-const
> argument as the first argument. So I remove the consts from
> the initializer.
> I replace typeof with __typeof__, which is always available
> in gcc - it is
> not, when the -ansi option is used.
And is it expected that Xen will EVER be compiled with -ansi? I think
there's enough gcc-isms in other places that this will never happen -
not that it really makes any difference, I'm just curious if anyone
"cares"...
--
Mats
>
> I do some explicit casts, which makes gcc errors more readable.
> In case, you pass an array by your mistake, which gets
> casted to a char *, then gcc tells you that rather just
> "invalid initializer".
>
> Christoph
>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|