 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] fix build when CONFIG_COMPAT disabled
| To: | Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] fix build when CONFIG_COMPAT disabled |
| From: | Keir Fraser <keir@xxxxxxxxxxxxx> |
| Date: | Thu, 11 Jan 2007 15:47:25 +0000 |
| Cc: | John Levon <levon@xxxxxxxxxxxxxxxxx> |
| Delivery-date: | Thu, 11 Jan 2007 07:47:08 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <45A668F1.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acc1l8oUCONcUKGLEduvagAX8io7RQ== |
| Thread-topic: | [Xen-devel] [PATCH] fix build when CONFIG_COMPAT disabled |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 11/1/07 15:42, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: > Properly conditionalize two places where compat-only structure fields get > accessed, and avoid compiler warnings on unused variables in two other > places. Should we bother to #ifdef where we don't need to? It's ugly and the compiler should be able to remove dead code where a condition evaluates to zero at compile time: we already have IS_COMPAT(d) hardcoded to zero if !CONFIG_COMPAT, which is enough to give the compiler a fair chance. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH] fix build when CONFIG_COMPAT disabled, Jan Beulich |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH 0/8] HVM save restore, Zhai, Edwin |
| Previous by Thread: | [Xen-devel] [PATCH] fix build when CONFIG_COMPAT disabled, Jan Beulich |
| Next by Thread: | Re: [Xen-devel] [PATCH] fix build when CONFIG_COMPAT disabled, John Levon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
