WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Add -Wcast-qual flag

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Add -Wcast-qual flag
From: "Christoph Egger" <Christoph.Egger@xxxxxxx>
Date: Thu, 21 Dec 2006 14:25:52 +0100
Cc: Keir Fraser <keir@xxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxxxx>
Delivery-date: Thu, 21 Dec 2006 05:32:21 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <458A915B.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: AMD / OSRC
References: <200612211105.21248.Christoph.Egger@xxxxxxx> <C1B01571.6AE9%keir@xxxxxxxxxxxxx> <458A915B.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.4
On Thursday 21 December 2006 13:51, Jan Beulich wrote:
> >>> Keir Fraser <keir@xxxxxxxxxxxxx> 21.12.06 11:41 >>>
> >
> >On 21/12/06 10:05, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
> >> The xen-cast.diff adds the -Wcast-qual flag.
> >
> >We don't enable this flag precisely because we end up needing to scatter
> >const all over the place like confetti. I'm not convinced that use of
> > const improves code quality. I fear we'd end up with 'const foo * const
> > bar' all over the place -- ugly and confusing to most programmers (who
> > frequently mess up const placement, in my experience).
>
> While I'd really like to see all Xen code become const-correct (because I
> do believe this helps with code quality, like does marking read only data
> read only in the page tables), I don't think adding the warning here is
> appropriate 

IMO, it is. It is one step towards to do more type-safe coding.

> - after all, in C this is one of the purposes of adding 
> explicit casts (although I agree it's questionable to use casts for this
> purpose). And no, I don't think that many people screwing up const
> placement is a proper argument for not using const where possible.

Full ack.

Christoph



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>