WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] [xend] Remove ':disk' suffix from device name in con

To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] [xend] Remove ':disk' suffix from device name in config
From: Jim Fehlig <jfehlig@xxxxxxxxxx>
Date: Tue, 19 Dec 2006 15:49:25 -0700
Delivery-date: Tue, 19 Dec 2006 14:53:47 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.8 (X11/20061025)
Remove ':disk' suffix from dev entry in dev_info dictionary in XendConfig.py.

The suffix is added regardless of device type (vbd or tap) so it doesn't appear to add any semantics. Additionally, clients would be forced to strip this suffix from the device name since something like 'hda:disk" is not a device name.

Regards,
Jim

# HG changeset patch
# User jfehlig@xxxxxxxxxxxxxxxxxxxxxxxxx
# Date 1166568442 25200
# Node ID 72a013bc923efa47b3262849cd5611a16353abc5
# Parent  057f7c4dbed1c75a3fbe446d346cee04cff31497
Remove ':disk' suffix from dev entry in dev_info dictionary in XendConfig.py.

The suffix was added regardless of device type so it doesn't appear to add any 
semantics.  Additionally, clients would be forced to strip this suffix from the 
device name since something like 'hda:disk" is not a device name.

Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxxxx>

diff -r 057f7c4dbed1 -r 72a013bc923e tools/python/xen/xend/XendConfig.py
--- a/tools/python/xen/xend/XendConfig.py       Tue Dec 19 12:00:11 2006 +0000
+++ b/tools/python/xen/xend/XendConfig.py       Tue Dec 19 15:47:22 2006 -0700
@@ -970,10 +970,10 @@ class XendConfig(dict):
             elif dev_type in ('vbd', 'tap'):
                 if dev_type == 'vbd':
                     dev_info['uname'] = cfg_xenapi.get('image', '')
-                    dev_info['dev'] = '%s:disk' % cfg_xenapi.get('device')
+                    dev_info['dev'] = cfg_xenapi.get('device')
                 elif dev_type == 'tap':
                     dev_info['uname'] = 'tap:qcow:%s' % cfg_xenapi.get('image')
-                    dev_info['dev'] = '%s:disk' % cfg_xenapi.get('device')
+                    dev_info['dev'] = cfg_xenapi.get('device')
                     
                 dev_info['driver'] = cfg_xenapi.get('driver')
                 dev_info['VDI'] = cfg_xenapi.get('VDI', '')
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] [xend] Remove ':disk' suffix from device name in config, Jim Fehlig <=