[Xen-devel] Re: [patch] Add kexec_ops & function pointers

To:	"Gerd Hoffmann" <kraxel@xxxxxxx>
Subject:	[Xen-devel] Re: [patch] Add kexec_ops & function pointers
From:	"Magnus Damm" <magnus.damm@xxxxxxxxx>
Date:	Tue, 12 Dec 2006 16:12:34 +0900
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Mon, 11 Dec 2006 23:12:29 -0800
Domainkey-signature:	a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=C3Y6N+yAUEEPip+kYcb9yIOZQLakrt2wRKThQfNx+OkBW8iy8h8bzby+BMlVQqeM4D4ouTPyOCfs9t5Z9gSm0/KfLQeR+WDH9WPhd3EljvmNk6nEyq7BskqktxgHISTasAtzpVBHdloJzO0eDP7549u9Salk1DwWdauiYEy2zF4=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<20061208161729.913385000@xxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<20061208161729.913385000@xxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Hi Gerd,

On 12/9/06, Gerd Hoffmann <kraxel@xxxxxxx> wrote:

Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxx>
---
 linux-2.6-xen-sparse/arch/i386/kernel/machine_kexec.c   |    2
 linux-2.6-xen-sparse/arch/x86_64/kernel/machine_kexec.c |    2
 linux-2.6-xen-sparse/drivers/xen/core/machine_kexec.c   |   42 +++++++-
 linux-2.6-xen-sparse/include/asm-i386/kexec.h           |   14 --
 linux-2.6-xen-sparse/include/asm-x86_64/kexec.h         |   13 --
 linux-2.6-xen-sparse/include/linux/kexec.h              |   24 ++--
 linux-2.6-xen-sparse/kernel/kexec.c                     |   80 +++++++++++-----
 7 files changed, 110 insertions(+), 67 deletions(-)


This version looks much cleaner. I've tested the code on i386 using
version 12898 and there was one small piece missing, see the attached
patch.

Basically, machine_kexec() should be converted to kexec_ops.kexec() in
two places. The second place is unfortunately located in
linux/kernel/sys.c which does not exist in sparse yet. So that needs
to be resolved somehow.

So apart from that I think the code looks very good. Thanks.

/ magnus

kexec_ops-fixes.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: [patch] Add kexec_ops & function pointers