Re: [Xen-devel] The patch fixes RAM above 4G unrecognized issue

[Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>]

At 19:40 +0800 on 05 Dec (1165347638), Cui, Dexuan wrote:
> --- a/xen/arch/x86/mm/shadow/common.c   Mon Dec 04 09:29:26 2006 +0000
> +++ b/xen/arch/x86/mm/shadow/common.c   Tue Dec 05 18:04:07 2006 +0800
> @@ -1246,7 +1246,7 @@ sh_gfn_to_mfn_foreign(struct domain *d,
>  /* Read another domain's p2m entries */
>  {
>      mfn_t mfn;
> -    unsigned long addr = gpfn << PAGE_SHIFT;
> +    uint64_t addr = ((uint64_t)gpfn) << PAGE_SHIFT;

Please use paddr_t for this kind of thing; it will be the right size on
all architectures.

>  #define PAGETABLE_ORDER         9
>  #define L1_PAGETABLE_ENTRIES    (1<<PAGETABLE_ORDER)
>  #define L2_PAGETABLE_ENTRIES    (1<<PAGETABLE_ORDER)
> -#define L3_PAGETABLE_ENTRIES    4
> -#define ROOT_PAGETABLE_ENTRIES  L3_PAGETABLE_ENTRIES
> +#define L3_PAGETABLE_ENTRIES    8
> +#define ROOT_PAGETABLE_ENTRIES  4

This will break all kinds of things.  I'll make a proper fix for 
sh_gfn_to_mfn_foreign() not to use l3_table_offset() instead.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel