 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [HVM][XENOPROFILE][PATCH] fix reversed test for mode fun
| To: | "Woller, Thomas" <thomas.woller@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [HVM][XENOPROFILE][PATCH] fix reversed test for mode function |
| From: | Keir Fraser <keir@xxxxxxxxxxxxx> |
| Date: | Fri, 01 Dec 2006 07:54:35 +0000 |
| Delivery-date: | Thu, 30 Nov 2006 23:54:38 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <683860AD674C7348A0BF0DE3918482F603BF48A3@xxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AccUxNJKXbh+wUkjTq2sw7PZxoJSVQAWR8CC |
| Thread-topic: | [Xen-devel] [HVM][XENOPROFILE][PATCH] fix reversed test for mode function |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 30/11/06 9:16 pm, "Woller, Thomas" <thomas.woller@xxxxxxx> wrote: > This patch fixes incorrect logic in the recently added > xenoprofile_get_mode() function. > On HVM guests the !guest_mode(regs) test will always succeed, so move > the is_hvm_vcpu() test first. > This change allows modes other than 2 to be returned properly for > xenoprofile for HVM guests. > > Signed-off-by: Tom Woller <thomas.woller@xxxxxxx> > Please apply to xen-unstable.hg. This is wrong. The actual problem is that you should be passing guest_cpu_user_regs() to xenoprofile_get_mode(). I'll fix that. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH] make shared_info architecture independent, He, Qing |
|---|---|
| Previous by Thread: | [Xen-devel] [HVM][XENOPROFILE][PATCH] fix reversed test for mode function, Woller, Thomas |
| Next by Thread: | [Xen-devel] FC6, xen 3.0.3, ia32, rpms from either FC6 repo or xensource, failing to start a vm, ron minnich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
