WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Allow mini-os to unbind all evtchns

To: Grzegorz Milos <gm281@xxxxxxxxx>, Jacob Gorm Hansen <jacobg@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Allow mini-os to unbind all evtchns
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Wed, 29 Nov 2006 12:25:37 +0000
Cc: xen-devel <Xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 29 Nov 2006 04:25:41 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <66C4E3ED-B00A-4A1E-8077-00C6C8A8748C@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccTsXliuAn5ZX+kEducNwAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Allow mini-os to unbind all evtchns
User-agent: Microsoft-Entourage/11.2.5.060620
On 29/11/06 12:16, "Grzegorz Milos" <gm281@xxxxxxxxx> wrote:

> The patch looks good to me. I only have one comment: it would be good
> to have unbind_all_ports in the events header file.

It looked bogus to me. What if event channels are bound/unbound/bound
multiple times during the mini-os lifetime (can't happen right now, but
maybe in future). The port array will overflow. Perhaps it should be a
bitmap instead (set on bind; clear on unbind)?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel