| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH 00/04] Kexec / Kdump: Release 20061122 (xen-unsta
|
To: |
Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, Magnus Damm <magnus@xxxxxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [PATCH 00/04] Kexec / Kdump: Release 20061122 (xen-unstable-12502) |
|
From: |
Keir Fraser <keir@xxxxxxxxxxxxx> |
|
Date: |
Tue, 28 Nov 2006 18:50:34 +0000 |
|
Cc: |
Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, Kazuo Moriwaka <moriwaka@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, magnus.damm@xxxxxxxxx, Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>, Isaku Yamahata <yamahata@xxxxxxxxxxxxx>, Horms <horms@xxxxxxxxxxxx> |
|
Delivery-date: |
Tue, 28 Nov 2006 10:50:37 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<1164738244.3336.214.camel@xxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
AccTHhXbVFUqiH8REduMhAANk04WTA== |
|
Thread-topic: |
[Xen-devel] [PATCH 00/04] Kexec / Kdump: Release 20061122 (xen-unstable-12502) |
|
User-agent: |
Microsoft-Entourage/11.2.5.060620 |
On 28/11/06 6:24 pm, "Ian Campbell" <Ian.Campbell@xxxxxxxxxxxxx> wrote:
> You define a per CPU variable crash_notes and on crash you loop over
> NR_CPUS and clear the notes for CPUS which don't exist. Unfortunately
> the percpu regions for CPUs which aren't physically present is returned
> to the heap on boot (see percpu_free_unused_areas) -- this means that
> you zero out heap pages on crash :-(
>
> You need to use num_{possible,present,online}_cpus() in
> machine_crash_kexec() and kexec_get_cpu() instead of NR_CPUS.
You should use for_each_cpu, for_each_present_cpu, or for_each_online_cpu.
Probably the last of those unless you care about dormant CPUs or hotplugged
CPU sockets. :-)
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home