WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] hvm_decode() questions

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] hvm_decode() questions
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Fri, 24 Nov 2006 14:08:16 +0000
Delivery-date: Fri, 24 Nov 2006 06:08:31 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <456709DE.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccP0fxeOsZ4DnvFEdupMAAX8io7RQ==
Thread-topic: [Xen-devel] hvm_decode() questions
User-agent: Microsoft-Entourage/11.2.5.060620


On 24/11/06 14:03, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> 1) single-byte opcode 0x87 (xchg): What is this strange conditional
> 
>         if ( ((*(opcode+1)) & 0xc7) == 5 )
> 
> supposed to address? xchg has absolutely symmetric operands.
> 
> 2) two-byte opcode 0xB7 (movzx): What is this dependency on rex
> bit 3 doing here? Apparently this was based on Intel's (broken)
> documentation - the source operand is always 16 bits.
> 
> Unless someone can explain these, I'll send a patch to remove them.

Yes, these can both be removed.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>