WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] support protected mode mmio with non-zero CS bas

To: Jan Beulich <jbeulich@xxxxxxxxxx>, Mats Petersson <Mats.Petersson@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] support protected mode mmio with non-zero CS base
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Wed, 22 Nov 2006 11:44:14 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 22 Nov 2006 03:44:33 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45644192.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccOK4iCxvs8VHoeEduTKwAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] support protected mode mmio with non-zero CS base
User-agent: Microsoft-Entourage/11.2.5.060620


On 22/11/06 11:24, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>> Yes, but it's also possibly incorrect if the machine is in "big
>> realmode", which is an entirely valid way to run code in x86 processors,
>> and I think it's better to fix it "properly" than to have to fix it
>> again when someone finds another fault in the code, because someone
>> wrote some code differently.
> 
> I meanwhile got convinced by Keir that this is indeed the better way.

Actually I disagree with you, but the patch was a strict improvement so I
checked it in as-is. But the realmode-specific path will go away in a future
patch, I'm quite sure.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel