On Fri, Nov 17, 2006 at 01:47:12PM +0000, Keir Fraser wrote:
> On 17/11/06 12:12, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:
>
> > Well there are two methods in libxc which expose a size_t argument so the
> > implicit method will break ABI changing these from 32 to 64 bits.
> >
> > xenctrl.h:int xc_tbuf_enable(int xc_handle, size_t cnt, unsigned long *mfn,
> > xenctrl.h:int xc_acm_op(int xc_handle, int cmd, void *arg, size_t arg_size);
>
> It'd be better probably to replace with explicit types and avoid
> off_t/size_t confusion at all. Maybe uint64_t.
Looking more closely at the python code, it appears the size_t parameters
do not get directly exposed to the python, so there should be no data
type size issues here to worry about - the size_t param is merely used
in the raw C code doing sizeof() on one of the other params. So the patch
you've already committed to put LFS flags in the top level makefile looks
like it'll be sufficient.
Regards,
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home