WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [Patch] Fix for x86_64 boot failures due to badsegment s

To: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Subject: RE: [Xen-devel] [Patch] Fix for x86_64 boot failures due to badsegment setup for protected mode.
From: "Stephen C. Tweedie" <sct@xxxxxxxxxx>
Date: Fri, 10 Nov 2006 16:09:01 +0000
Cc: Wilfred Yu <wilfred.yu@xxxxxxxxx>, Xiaohui Xin <xiaohui.xin@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Herbert Xu <herbert.xu@xxxxxxxxxx>, Susie Li <susie.li@xxxxxxxxx>, Steven Rostedt <srostedt@xxxxxxxxxx>, "Li, Xin B" <xin.b.li@xxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
Delivery-date: Fri, 10 Nov 2006 08:09:30 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <391BF3CDD2DC0848B40ACB72FA97AD596CE372@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <391BF3CDD2DC0848B40ACB72FA97AD596CE372@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi,

On Fri, 2006-11-10 at 22:39 +0800, Jiang, Yunhong wrote:
> This patch caused one problem.
> 
> If the guest change the DS/SS etc between it set cr0.PE and the jump 
> instruction.

Hmm...  Do you know how much of a problem that causes in practice?
Which guests have that behaviour?

> Considering following code:
>    mov eax, cr0
>    or eax, 0x11
>   mov cr0, eax                ---> here enable PE, and old_ctx.ds is cleard
>    mov ax, 0x0020
>    mov ds, ax         -> changes the DS here

Well, we've got commit log comments for the "pop %es" case:

2) In
current vmxassist, when entering VM86_PROTECTED_TO_REAL, we need to
decode every instruction manually until we catch instructions like
jmpl to reset cs to really return to real mode.

So I'm afraid I just assumed that we wouldn't need to deal with ds in
real life, since we haven't added emulation for that so far.  Is that
emulation we need to add as a matter of some urgency, then?

--Stephen



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel