WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] remove HVM halt timer

To: "Li, Xin B" <xin.b.li@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] remove HVM halt timer
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 10 Nov 2006 08:15:10 +0000
Delivery-date: Fri, 10 Nov 2006 00:15:34 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <B30DA1341B0CFA4893EF8A36B40B5C5D62EA26@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccEnswNUkAD/BhaQT+W4uZ/emiWdAAAYqyK
Thread-topic: [Xen-devel] [PATCH] remove HVM halt timer
User-agent: Microsoft-Entourage/11.2.5.060620
On 10/11/06 8:04 am, "Li, Xin B" <xin.b.li@xxxxxxxxx> wrote:

> remove HVM halt timer.
> It's no longer needed since interrupts can wake it up now; using
> vcpu_unblock instead of vcpu_kick because timer callback functions are
> executed on the precossor the target vcpu is on.

Why do you replace use of the schedop_block hypercall with direct setting of
the blocked flag and softirq? Also vcpu_kick() has negligible extra cost
compared with vcpu_unblock() and it's less confusing just to use it
everywhere. Most people don't remember the semantic difference.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel