Re: [Xen-devel] [PATCH] Crash VMX when guest NMI.

To:	"Li, Xin B" <xin.b.li@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] Crash VMX when guest NMI.
From:	Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date:	Wed, 08 Nov 2006 15:00:56 +0000
Delivery-date:	Wed, 08 Nov 2006 07:01:20 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<B30DA1341B0CFA4893EF8A36B40B5C5D5EB0F4@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AccDN511UfGvNDRNTg6JySMxT0rV1wADxPNZ
Thread-topic:	[Xen-devel] [PATCH] Crash VMX when guest NMI.
User-agent:	Microsoft-Entourage/11.2.5.060620

On 8/11/06 13:13, "Li, Xin B" <xin.b.li@xxxxxxxxx> wrote:

> Crash VMX when guest NMI.
> It's meanless to call do_nmi of Xen HV when guest NMI, and acturally
> guest NMI can only be injected, is it possible to happen inside guest?
> 
> Signed-off-by: Xin Li <xin.b.li@xxxxxxxxx>

That path is taken for real NMIs. We shouldn't take it for exceptions on
vector 2 as bit 2 is not set in the exception-intercept bitmap.

However, I'll add a patch to actually check the INTRO_INFO_TYPE_MASK before
calling do_nmi(). Certainly we should only do_nmi() if the type is NMI (2).

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] Crash VMX when guest NMI.