WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] fix non-dom0 backend watches

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] fix non-dom0 backend watches
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Wed, 8 Nov 2006 00:57:23 +0000
Delivery-date: Tue, 07 Nov 2006 16:57:38 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
(I was personally not sure about this one: it seems to allow someone to
watch a 'private' path and receive confirmation of its existence, which
previously was prevented. However, it looks like this is what Keir is
suggesting in the following discussion:
http://thread.gmane.org/gmane.comp.emulators.xen.devel/31710/focus=31711
Of course I'm far from an expert on how xenstore's permissions system is
supposed to work, and the patch certainly fixes a real problem.)

regards
john


# HG changeset patch
# User john.levon@xxxxxxx
# Date 1162947187 28800
# Node ID 8b9a88f3b4070bae7892f1e36bcbb7ad896ce674
# Parent  98aaea71c6312dfc80c07194a9b7e1de7f021c94
Fire watch for non-dom0 backend when frontend is removed from xenstore in a
transaction.

Signed-off-by: Max Zhen <max.zhen@xxxxxxx>

diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c
--- a/tools/xenstore/xenstored_watch.c
+++ b/tools/xenstore/xenstored_watch.c
@@ -60,7 +60,7 @@ static void add_event(struct connection 
        if (!check_event_node(name)) {
                /* Can this conn load node, or see that it doesn't exist? */
                struct node *node = get_node(conn, name, XS_PERM_READ);
-               if (!node && errno != ENOENT)
+               if (!node && errno != ENOENT && errno != EACCES)
                        return;
        }
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] fix non-dom0 backend watches, John Levon <=