WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xm-test: don't export RD_PATH into TENV

To: Ryan Harper <ryanh@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xm-test: don't export RD_PATH into TENV
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: Thu, 2 Nov 2006 23:06:17 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 02 Nov 2006 21:40:32 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061101225949.GP12095@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20061101225949.GP12095@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Wed, Nov 01, 2006 at 04:59:49PM -0600, Ryan Harper wrote:

> xm-test currently exports the RD_PATH value into the environment which
> prevents one from providing the value when running a test.  Without this
> patch, one has to re-run ./autogen && ./configure with RD_PATH defined
> to change the RD_PATH value that is used.
> 
> Additionally, the current getRdPath() implementation already uses the
> the value that was being exported.  In short, exporting the value is not
> needed unless one wants to override the default value.
> 
> With the patch, the following now works:
> 
> % cp xm-test/ramdisk/initrd.img /boot
> % cd xm-test/tests/create
> % RD_PATH=/boot TEST_VERBOSE=1 make TESTS=01_create_basic_pos.test check

Applied, thanks Ryan.

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>