|
|
|
|
|
|
|
|
|
|
xen-devel
[Xen-devel] Re: clear redunadant IRQ disable
To: |
"Dong, Eddie" <eddie.dong@xxxxxxxxx>, Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, "Yu, Ke" <ke.yu@xxxxxxxxx>, Christian Limpach <christian.limpach@xxxxxxxxx> |
Subject: |
[Xen-devel] Re: clear redunadant IRQ disable |
From: |
Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
Date: |
Tue, 31 Oct 2006 09:38:49 +0000 |
Cc: |
xen-devel@xxxxxxxxxxxxxxxxxxx, "Huang, Xinmei" <xinmei.huang@xxxxxxxxx> |
Delivery-date: |
Thu, 02 Nov 2006 13:51:38 -0800 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
In-reply-to: |
<0E6FE5D295DE5B4B8D9070C26A227987538569@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Thread-index: |
Acbwn3GTeQX7YqjuSrWHsAKaEOOOQwANzaogAF+2ZZACaGUm0AAEkMSwAAbrrDAAAklb1wAAHUJQACYey+AAAlAZYg== |
Thread-topic: |
clear redunadant IRQ disable |
User-agent: |
Microsoft-Entourage/11.2.5.060620 |
On 31/10/06 08:38, "Dong, Eddie" <eddie.dong@xxxxxxxxx> wrote:
> Clear the redundant code in vmx_load_cr2 and use got "%EBX" for current
> vcpu pointer.
vmx_load_cr2() simplification is worthwhile but I'm not sure about 'vcpu *'
as a parameter to various functions. It's cheap to compute current and it's
actually confusing sometimes whether a function takes an arbitrary vcpu or
whether it is allowed to assume current. This is made obvious if the
function grabs current for itself.
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|