WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Create command fail if giving an empty disk file path, s

To: "You, Yongkang" <yongkang.you@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Create command fail if giving an empty disk file path, such as ', hdc:cdrom, r'
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 23 Oct 2006 12:02:12 +0100
Delivery-date: Mon, 23 Oct 2006 04:02:52 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <094BCE01AFBE9646AF220B0B3F367AAB58913D@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acb2gOPOYZ93C0C1TB6YjcygLMyn7AAEc0Wc
Thread-topic: [Xen-devel] Create command fail if giving an empty disk file path, such as ', hdc:cdrom, r'
User-agent: Microsoft-Entourage/11.2.5.060620
On 23/10/06 09:54, "You, Yongkang" <yongkang.you@xxxxxxxxx> wrote:

> The easiest fixing is to add judgment to resource. If so, Guests can be
> created 
> even if not providing any disk image file, and let the boot process to tell
> that 
> user didn't give the right disk. This is also the used to be. But I am not
> sure if it is 
> an acceptable fixing. Could anybody give some advice?

Seems okay. It'd be nice not to execute that path *at all* if ACM is not
being used, or at least give a useful error message if the split on ':'
fails.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>