WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH][ACM] 2/3: make ACM architecture independent

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH][ACM] 2/3: make ACM architecture independent (Xen part)
From: Stefan Berger <stefanb@xxxxxxxxxx>
Date: Wed, 18 Oct 2006 13:22:46 -0400
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Reiner Sailer <sailer@xxxxxxxxxx>, xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 18 Oct 2006 10:23:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C15C167F.2BF0%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

xen-devel-bounces@xxxxxxxxxxxxxxxxxxx wrote on 10/18/2006 12:35:59 PM:

>
>
> On 18/10/06 16:57, "Stefan Berger" <stefanb@xxxxxxxxxx> wrote:
>
> > This patch moves the multiboot-specific part of the ACM initialization
> > into its own file. Any architecture that implements the multiboot
> > specification should be able to reuse this function for booting a
> > machine with an ACM policy.
> > It also moves the x86-specific functions into an x86 include file.
> >
> > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>
>
> Hmm... It's a single small function with a fairly nasty interface. I don't
> think making it arch-independent is a good idea. I already shrunk the
> function down a bit when applying Tristan's patch so it's not actually very
> big.
>
> My main issue is that it is intertwined with the variables that setup.c
> maintains to track multiboot modules. It would be cleaner to make more of
> setup.c arch-independent and carry the acm_multiboot function with it. All
> the while the rest is inside arch/x86, I think acm_multiboot should stay
> there too.


I'll see what I can do.

>
> I did take your third patch, by the way (tools alignment change).


You took parts 1 and 3, but not 2? In that case I would have to rip out some of the alignment parts from the 2nd part and send them again.

  Stefan

>
>  -- Keir
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel