WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] fix asm syntax

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix asm syntax
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Tue, 17 Oct 2006 17:04:25 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Jan Beulich <jbeulich@xxxxxxxxxx>
Delivery-date: Tue, 17 Oct 2006 09:04:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C15ABA05.2AA3%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20061017154255.GA12609@xxxxxxxxxxxxxxxxxxxx> <C15ABA05.2AA3%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Tue, Oct 17, 2006 at 04:49:09PM +0100, Keir Fraser wrote:

> On 17/10/06 16:42, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:
> 
> > The standard GNU ld is currently still 2.15 on Solaris. If there's
> > serious objections to not using the newer syntax, we can always keep it
> > as a local hack until we've updated. We're releasing our sources after
> > all.
> 
> 2.15 supports the rex64/ syntax, I'm certain. It's the default binutils on
> my Debian build box. If you get a build failure with that version, that's
> rather suspect.

You're right. I looked closer at the problem. It's this code:

   1689       if (!is_space_char (*l)
   1690           && *l != END_OF_INSN
   1691           && (intel_syntax
   1692               || (*l != PREFIX_SEPARATOR
   1693                   && *l != ',')))
   1694         {
   1695           as_bad (_("invalid character %s in mnemonic"),
   1696                   output_invalid (*l));

On sysv targets:

    211 #define PREFIX_SEPARATOR '\\'

Possibly --divide should alter the semantics in this case too. It's
something I need to bring up on the binutils list, but in the meantime,
it seems like a bug we have to work around.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel