 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Introduce Makefile config fragments for OS-speci
| To: | John Levon <levon@xxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Introduce Makefile config fragments for OS-specific differences. |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Tue, 17 Oct 2006 16:09:22 +0100 |
| Delivery-date: | Tue, 17 Oct 2006 08:09:54 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20061017124257.GB4626@xxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acbx/jnHeBCLkl3xEduPAgAX8io7RQ== |
| Thread-topic: | [Xen-devel] [PATCH] Introduce Makefile config fragments for OS-specific differences. |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 17/10/06 13:42, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote: > -ifneq ($(debug),y) > -# Optimisation flags are overridable > -CFLAGS ?= -O2 -fomit-frame-pointer > -CFLAGS += -DNDEBUG > -else > -# Less than -O1 produces bad code and large stack frames > -CFLAGS ?= -O1 -fno-omit-frame-pointer > -CFLAGS += -g > -endif Generally this patch is fine, but does the above chunk have to be made OS-specific? Does Solaris specifically have something against -fomit-frame-pointer? Also, moving KERNEL_REPO/KERNELS/XKERNELS seems unnecessary. There are still rules consuming those variables in the root Makefile, so leaving KERNELS/XKERNELS nearby makes sense to me. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] fix asm syntax, Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] fix asm syntax, John Levon |
| Previous by Thread: | [Xen-devel] [PATCH] Introduce Makefile config fragments for OS-specific differences., John Levon |
| Next by Thread: | Re: [Xen-devel] [PATCH] Introduce Makefile config fragments for OS-specific differences., John Levon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
