This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [Xen-changelog] [xen-unstable] [VMXASSIST] Cast to point

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [Xen-changelog] [xen-unstable] [VMXASSIST] Cast to pointer type via long to avoid compile
From: Rik van Riel <riel@xxxxxxxxxx>
Date: Thu, 28 Sep 2006 15:23:20 -0400
Delivery-date: Thu, 28 Sep 2006 12:24:01 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <E1GSfQG-0007FB-Ao@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1GSfQG-0007FB-Ao@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20060913)
Xen patchbot-unstable wrote:

[VMXASSIST] Cast to pointer type via long to avoid compile
warnings/errors with latest gcc versions.
Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>

Are you sure you don't want these to be unsigned, seeing that
the x86-64 kernels have the top bit set for kernel addresses?

diff -r 5c522692edd1 -r 1d0e75523636 tools/firmware/vmxassist/vm86.c
--- a/tools/firmware/vmxassist/vm86.c   Wed Sep 27 16:22:17 2006 +0100
+++ b/tools/firmware/vmxassist/vm86.c   Wed Sep 27 17:49:22 2006 +0100
@@ -68,7 +68,7 @@ guest_linear_to_real(uint32_t base)
                return base;
if (!(oldctx.cr4 & CR4_PAE)) {
-               l1_mfn = ((uint32_t *)gcr3)[(base >> 22) & 0x3ff];
+               l1_mfn = ((uint32_t *)(long)gcr3)[(base >> 22) & 0x3ff];

All Rights Reversed

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>