This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] allow connecting to xenconsole from remote hosts

To: Muli Ben-Yehuda <muli@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] allow connecting to xenconsole from remote hosts
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 13 Sep 2006 15:08:48 +0100
Cc: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Anthony Liguori <anthony@xxxxxxxxxxxxx>, Orran Y Krieger <okrieg@xxxxxxxxxx>
Delivery-date: Wed, 13 Sep 2006 07:07:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060913135904.GG5723@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbXPiGzYA0pmkMxEdu3oQAX8io7RQ==
Thread-topic: [PATCH] allow connecting to xenconsole from remote hosts
User-agent: Microsoft-Entourage/

On 13/9/06 14:59, "Muli Ben-Yehuda" <muli@xxxxxxxxxx> wrote:

>> You still have that message/queue struct stuff. Is it needed, especially now
>> that noecho is gone?
> I need someplace to keep what we read from a source fd until the
> destination fd becomes writable. The original code just assumed
> everything is writable and wrote it immediately; this assumption may
> not be correct when the destination fd is a socket.

A character array would be more obvious. This will also allow an easy
implementation of console logging in the future -- the character array will
simply be an mmap'ed log file, where the log is rotated whenever the cursor
reaches the end of the buffer array.

 -- Keir

Xen-devel mailing list