This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Paravirt framebuffer console cleanups [5/5]

> > > > This whole passage is a little peculiar, in that you're only going to
> > > > do anything if use_graphics is disabled.  I'd expect that just leaving
> > > > the current behaviour alone would be the correct thing to do in that
> > > > case.
> > > > 
> > > > Also, why do you need to set CON_CONSDEV at all?
> > > Otherwise, you don't get kernel console messages.
> > Why not?  None of the other console drivers seem to need to set it
> > explicitly, and it seems like it would break setting console=blah on
> > the kernel command line.
> Nothing else sets it explicitly because it happens implicitly in the
> console registration code for the first thing registered with
> register_console().  Alternately, if you have a console=, then
> register_console ensures that your console device has CON_CONSDEV set.
> kernel/printk.c if you want to read all the gory details
The intent of this code seems to be to make sure that CON_CONSDEV is
definitely set on xenconsole if use_graphics is not set, yes?  But as
far as I can see, if use_graphics is not set, xenfb should never call
register_console(), and so this is all redundant.

What am I missing?


Attachment: signature.asc
Description: Digital signature

Xen-devel mailing list